fix: AutoComplete hinter should link to p5js.org for v2, and v1.p5js.org - #4234
fix: AutoComplete hinter should link to p5js.org for v2, and v1.p5js.org#4234ksen0 wants to merge 3 commits into
Conversation
Fixes #4233
ksen0
changed the title
|
Hi @raclim @doradocodes , fixing this problem is a prereq for making the hinter default! Also tagging @skyash-dev - if this PR is incomplete, and you'd like to make an alternative PR, please feel free. In that case I can close this one, I haven't tested it. The issue came up when we were doing the v2 default switch on the editor and I made the PR mainly as a reminder. |
khanniie
left a comment
khanniie
left a comment
There was a problem hiding this comment.
I tested this locally and it LGTM! thanks Kit!
| const VERSIONS = [ | ||
| { | ||
| version: 'v1', | ||
| url: 'https://v1.p5js.org/reference/data.json' |
There was a problem hiding this comment.
we don't want to show v2 hints here (which beta reference data includes), right? we can keep v1 here.
There was a problem hiding this comment.
Thanks for catching this, I removed the stray changes!
| }, | ||
| { | ||
| version: 'v2', | ||
| url: 'https://p5js.org/reference/data.json' |
There was a problem hiding this comment.
we can also keep this as beta is now live. (changes to these urls are already done here)
3 participants
Fixes #4233
Demo:
Changes:
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123